Issue91 flit bisect buildrace #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because this was also a race. We also will not know which files need to be compiled with fPIC, so it (1) has minimal sharing so not large impact, and (2) precompiling them will cause us to potentially create way more object files than necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build race when executing parallel bisect
were competing to write and read the same object files
--deleteflag. They aredeleted after all is done.
-fPICcompiled object files to within the bisect object directory instead ofthe top-level object directory. This is because we can again contend for the
creation of these files with parallel bisect invocations.