Issue229 bisect deadlock #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebentley15
added
bug
python
mikebentley15
commented
Oct 10, 2018
- Comment about result_queue.put() describing why it is there - Reraise the exception so that the exception will be printed to stderr for debugging
Under --verbose, subp.Popen() is used incorrectly and can still cause a deadlock. This is now fixed.
IanBriggs
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #229
Description:
makefromflit bisectis not in a consolidated function calledrun_make(). This function will output the standard out and error to the log in the case of an error.--auto-sqlite-runmode.Documentation:
No documentation update necessary. This was fixing existing functionality.
Tests:
run_make()within the docstring there.