Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue239 clang nopie #242

Merged
merged 10 commits into from
Dec 4, 2018
Merged

Issue239 clang nopie #242

merged 10 commits into from
Dec 4, 2018

Conversation

mikebentley15
Copy link
Collaborator

Fixes #239

Description:

  • Add an extra conditional check for Clang within the generated Makefile
  • For Clang, use -nopie instead of -no-pie when linking
  • CC changed to CXX to reflect it as a C++ compiler instead of a C compiler
  • Remove "MPI is enabled" message from the Makefile

Documentation:
No documentation was updated since this was already supposed to be supported.

I suppose we should document that we support Clang 3.4+ and GCC 4.8+

Tests:

  • Updated the MPI test removing the section checking for the "MPI is enabled" message
  • Added tests for Clang 3.4 and GCC 4 where the compilers are faked and checked against known allowed flags.

@mikebentley15 mikebentley15 added bug python Involves touching python code make Involves touching GNU Makefiles documentation Involves touching documentation tests Involves touching tests labels Nov 27, 2018
@mikebentley15
Copy link
Collaborator Author

The documentation has been updated to reflect the minimum versions of each compiler.

@mikebentley15
Copy link
Collaborator Author

Also fixes #191

@IanBriggs IanBriggs merged commit 330bbef into devel Dec 4, 2018
@IanBriggs IanBriggs deleted the issue239-clang-nopie branch December 4, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Involves touching documentation make Involves touching GNU Makefiles python Involves touching python code tests Involves touching tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants