Issue210/src compiled all in one #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only does help, check, clean, install, and uninstall
MPI tests fixed: Done by replacing a global variable with a static variable of a static inline function. This removes undefined behavior since we are not guaranteed the order in which global variables are initialized.
The old #include "flit.h" will still work but is depricated
The wrong path was given as include_dir
- spell check - remove obsolete sections - remove sections describing FLiT's compilation - add description of how and why dynamic compiling of FLiT was done
mikebentley15
added
bug
python
JohnJacobsonIII
approved these changes
Feb 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210
Description:
Changed the FLiT source code to be compiled each time into each test executable. Not only this, but to do a Unity Build with the FLiT source code to make it faster.
src/tosrc/flit/src/flit.hfor backward-compatibilityflit.hfile intosrc/flit/flit.hsrc/flit/ALL-FLIT.cppfor a Unity Build of FLiT#include <flit/...>instead ofdirectly
#include "...".libflit.soMakefilefor regular flit and for bisect to compile inALL-FLIT.cppinto every test executable.(also get
flit experimental ninjaworking this way)make installDocumentation:
Tests:
tests/flit_install/tst_install_runthrough.pyto check for newlyinstalled source files
assumed (i.e., fix of C++ undefined behavior)