Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Adding support for bicep v0.22.6 #81

Merged
merged 10 commits into from
Oct 29, 2023
Merged

Adding support for bicep v0.22.6 #81

merged 10 commits into from
Oct 29, 2023

Conversation

PalmEmanuel
Copy link
Member

@PalmEmanuel PalmEmanuel commented Oct 22, 2023

Pull Request

Pull Request (PR) description

Added

  • Support for Bicep v0.22.6

Changed

  • Version changed to 2.3.0

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Markdown help added/updated.
  • Unit tests added/updated.

@PalmEmanuel
Copy link
Member Author

PalmEmanuel commented Oct 22, 2023

Export-BicepNetResource has broken between the versions.

EDIT: Fixed in later commit e45770e

image

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Linux Test Results

224 tests  ±0   224 ✔️ ±0   2s ⏱️ -1s
  32 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 2ec1408. ± Comparison against base commit 3bbc894.

♻️ This comment has been updated with latest results.

@PalmEmanuel
Copy link
Member Author

PalmEmanuel commented Oct 22, 2023

Restore-BicepNetFile has also changed internally since last version where it works as intended. It still seems to restore modules, but implies that it didn't find any modules even after successfully restoring them.

image

EDIT: Solved in later commit 2ec1408, problem was that it defaults to restoring when creating the compilation now, so our "second" restore did nothing.

@PalmEmanuel
Copy link
Member Author

Set-BicepNetCredential or Get-BicepNetAccessToken seems to not work anymore, even in currently released version.

We should probably rework these completely with AzAuth anyway now that it has full support for tokencache persistence, so I suggest we go ahead with this PR without poking at those.

@PalmEmanuel
Copy link
Member Author

Everything compiles and all commands seem to be working when testing manually.

No new features implemented yet from Bicep, but the PR is ready for a review now!

@PalmEmanuel PalmEmanuel marked this pull request as ready for review October 22, 2023 17:03
Copy link
Member

@SimonWahlin SimonWahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works with all tests in PSBicep

@SimonWahlin SimonWahlin merged commit 1d509e5 into main Oct 29, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants