Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Implement Support for v0.24.24 #87

Merged
merged 8 commits into from
Jan 7, 2024
Merged

Implement Support for v0.24.24 #87

merged 8 commits into from
Jan 7, 2024

Conversation

PalmEmanuel
Copy link
Member

Pull Request

Pull Request (PR) description

This PR implements support for Bicep assemblies for v0.24.24.

.NET 8 now scans your packages for vulnerabilities and won't build if they have (good). Bicep.Core uses Azure.Identity version 1.9 which has vulnerabilities, so BicepNet wouldn't build (bad). I added a global.json file to the project to match the version that Bicep uses, which allows Bicep to build, and in turn BicepNet.

Added

  • Support for Bicep v0.24.24.

Security

  • Added global.json to match Bicep project build config. This allows the project to build without .NET 8 vulnerability scanning.

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).

Copy link

github-actions bot commented Jan 7, 2024

Linux Test Results

240 tests   240 ✅  2s ⏱️
 32 suites    0 💤
  1 files      0 ❌

Results for commit 5171958.

♻️ This comment has been updated with latest results.

@PalmEmanuel
Copy link
Member Author

I loaded it manually with PSBicep and it seems to be working now after a few adjustments, all tests passed except for the bicepconfig comparison (which is correct, since it's updated).

Ready for review!

Copy link
Member

@SimonWahlin SimonWahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Also runs all test from PSBicep successfully

@SimonWahlin SimonWahlin merged commit 18665b4 into main Jan 7, 2024
5 of 6 checks passed
@SimonWahlin SimonWahlin deleted the v0.24.24 branch January 7, 2024 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants