Timers: Support 16 bit timer writes and reset even when interrupts are disabled #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scheduler doesn't need to know if the timer (both IOP and EE) can target because the timer needs to reset regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my hardware tests, these are my findings.
EE Timers
Regardless of bit 8 (Compare Interrupt Enable), if bit 6 (Clear counter when it reaches compare value) is set, the timer will be reset.
IOP Timers
Bit 3 (Zero return - reset counter on interrupt) is incorrectly documented, regardless of interrupt setting, the timer count will be reset when it reaches the target if this bit is set.
Also, support 16 bit writes, they work on real hw (thanks, Ziemas)