Logic revisions needed in build_release.sh script

[martinholmer]

The Release Process described in webapp-public issue 560 implies, it seems to me, the need for some fundamental changes in the logic of the build_release.sh script. My thoughts on this are part of the 560 discussion. I'm linking here to that comment here because it is here in the policybrain-builder repository that these logic changes need to be made.

[martinholmer]

@jbcrail, Thanks for fixing issue #43.

As I first said almost a week ago in issue #49, the Release Process described in webapp-public issue 560 implies the need for some fundamental changes in the logic of the build_release.sh script.

There are two main design changes:

(1) make the script operate on one, and only one, OSPC repository at a time, and

(2) remove from the script any logic that changes the taxcalc version in the requirements section of a repository's conda.recipe/meta.yaml file.

Here are some implications of those two design changes:

(a) Because the script is building conda packages with a specified name (taxcalc, ogusa, or btax) and a specified repo release tag (e.g., 0.1.6 for btax), the name of the script should be changed to build_packages.sh. It is conda packages that are being built and optionally uploaded to anaconda.org.

(b) The SKIP_TAXCALC, SKIP_OGUSA, and SKIP_BTAX variables should be replaced by one variable that specifies the kind of packages being built: PKG_NAME. This new variable would have (at the moment) just three valid values: taxcalc, ogusa, btax. The script would know how to translate the specified package name into the repository's name, etc.

(c) The TAXCALC_TAG variable should be replaced by a variable that specifies the release tag being used to build the packages: PKG_TAG.

It seems to me, that these changes are essential if the build_packages.sh script is to support the new Release Process. But maybe I've missed something or I am confused. If so, please let me know how you think the script should be revised to support the new Release Process.

@MattHJensen @PeterDSteinberg

[martinholmer]

Pull request #52 by @jbcrail resolved issue #49. Thanks, @jbcrail.