Fix logic of the run_nth_year_gdp_elast_model function #1677
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1677 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 2856 2880 +24
======================================
+ Hits 2856 2880 +24
Continue to review full report at Codecov.
|
| @@ -177,7 +177,7 @@ def run_nth_year_gdp_elast_model(year_n, start_year, | |||
|
|
|||
| # calculate gdp_effect | |||
| fyear = check_years_return_first_year(year_n, start_year, use_puf_not_cps) | |||
| if (start_year + year_n) > fyear: | |||
| if year_n > 0 and (start_year + year_n) > fyear: | |||
| # create calc1 and calc2 calculated for year_n - 1 | |||
There was a problem hiding this comment.
@martinholmer what condition are you checking here if (start_year + year_n) > fyear:?
There was a problem hiding this comment.
year_n can be zero even if (start_year + year_n) is greater than fyear,
which is equal to the value returned by this function:
def check_years_return_first_year(year_n, start_year, use_puf_not_cps):
"""
Ensure year_n and start_year values are valid given input data used.
Return value of first year, which is maximum of first records data year
and first policy parameter year.
"""
|
@martinholmer this looks good. Thanks for the quick turn around. |
RELEASES.md
Outdated
| @@ -22,9 +22,6 @@ for a complete commit history. | |||
| - Add new policy parameter that changes the stacking order of child/dependent credits | |||
| [[#1676](https://github.com/open-source-economics/Tax-Calculator/pull/1676) | |||
| by Matt Jensen as suggested by Cody Kallen] | |||
There was a problem hiding this comment.
Could this read:
by Matt Jensen as suggested by Cody Kallen and with need identified by JEC staff.
There was a problem hiding this comment.
or better yet, 'Joint Economic Committee staff'
|
Thanks for the latest commit @martinholmer |
This pull request fixes a bug identified by @hdoupe in PolicyBrain 738.
This pull request adds a test to
test_tbi.pythat fails on the master branch (recreating the error reported by @hdoupe) and passes on this branch, which includes a one-line change to therun_nth_year_gdp_elast_modelfunction.Thanks, @hdoupe, for the concise bug report.
@MattHJensen @Amy-Xu @andersonfrailey @GoFroggyRun