Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine child/dependent input parameters #53

Merged
merged 6 commits into from
Nov 6, 2020

Conversation

Peter-Metz
Copy link
Collaborator

This PR redefines the child/dependent input parameters to be more intuitive. Results are unchanged.

Before this PR, the child/dependent inputs were:

  • Number of dependents
  • Number of children under 13 with eligible child care expenses
  • Number of children under 17 for the entire tax year
  • Number of qualifying children for EITC

This PR proposes the following child/dependent inputs:

  • Number of children under 13
  • Number of children from 13 to 16
  • Number of children from 17 to 18 AND from 19 to 24 and a full-time student
  • Other dependents

I've gotten feedback from multiple people that the current inputs are confusing and that the error messages are not helpful. I am hoping that the new format is clearer. Feedback is welcome

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #53 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   86.71%   86.84%   +0.13%     
==========================================
  Files           3        3              
  Lines         399      403       +4     
==========================================
+ Hits          346      350       +4     
  Misses         53       53              
Impacted Files Coverage Δ
taxcrunch/cruncher.py 81.04% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98b211...25a5820. Read the comment docs.

@Peter-Metz Peter-Metz merged commit e1ebc48 into PSLmodels:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants