Skip to content

Conversation

@MariusStorhaug
Copy link
Member

Description

This pull request includes several changes to improve the handling of null or empty string checks in various PowerShell scripts. The updates primarily involve replacing custom IsNullOrEmpty function calls with the built-in [string]::IsNullOrEmpty method to enhance readability and maintainability.

Improvements to null or empty string checks:

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Mar 7, 2025
Copilot AI review requested due to automatic review settings March 7, 2025 22:09
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner March 7, 2025 22:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@MariusStorhaug MariusStorhaug moved this from 🆕 New to 🏗 In progress in PSModule Framework Mar 7, 2025
@MariusStorhaug MariusStorhaug merged commit d778e56 into main Mar 7, 2025
10 checks passed
@MariusStorhaug MariusStorhaug deleted the fixUtils branch March 7, 2025 22:40
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in PSModule Framework Mar 7, 2025
MariusStorhaug added a commit that referenced this pull request Mar 7, 2025
MariusStorhaug added a commit that referenced this pull request Mar 7, 2025
## Description

This reverts commit d778e56.

## Type of change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] 📖 [Docs]
- [ ] 🪲 [Fix]
- [x] 🩹 [Patch]
- [ ] ⚠️ [Security fix]
- [ ] 🚀 [Feature]
- [ ] 🌟 [Breaking change]

## Checklist

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants