Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for PSPDFKit 9 for iOS #42

Merged
merged 4 commits into from
Sep 19, 2019
Merged

Update for PSPDFKit 9 for iOS #42

merged 4 commits into from
Sep 19, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Sep 12, 2019 •
edited
Loading

⚠️ Only merge once PSPDFKit 9 for iOS is out ⚠️

Details

This PR updates our Flutter plugin for compatibility with PSPDFKit 9 for iOS.

Acceptance Criteria

  • Integration into a newly created app works.
  • The example project works with PSPDFKit 9 for iOS.

@radazzouz radazzouz self-assigned this Sep 12, 2019
@radazzouz radazzouz changed the title Update for PSPDFKit 9 for iOS [WIP] Update for PSPDFKit 9 for iOS Sep 12, 2019
@radazzouz radazzouz added the READY TO REVIEW Pull request ready to review label Sep 16, 2019
@radazzouz radazzouz requested a review from aksh1t September 16, 2019 19:28
@radazzouz radazzouz added the HOLD Hold label Sep 16, 2019
@radazzouz radazzouz changed the title [WIP] Update for PSPDFKit 9 for iOS Update for PSPDFKit 9 for iOS Sep 16, 2019
aksh1t
aksh1t approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@aksh1t aksh1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small numbering typo in the readme, but everything else looks great!

@matej matej merged commit 61083da into master Sep 19, 2019
@matej matej deleted the rad/ios-v9.0 branch September 19, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aksh1t aksh1t aksh1t approved these changes

Assignees

@radazzouz radazzouz

Labels
HOLD Hold iOS READY TO REVIEW Pull request ready to review update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radazzouz @aksh1t @matej