Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example project warnings and update its build system from legacy to the new one #53

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Fix example project warnings and update its build system from legacy to the new one #53

merged 2 commits into from
Jan 20, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jan 17, 2020 •
edited
Loading

Details

This does not impact Android.

Acceptance Criteria

  • Before merging retest all the examples to make sure that they work on both Android and iOS.

@radazzouz radazzouz added enhancement New feature or request iOS READY TO REVIEW Pull request ready to review labels Jan 17, 2020
@radazzouz radazzouz requested a review from aksh1t January 17, 2020 13:58
@radazzouz radazzouz self-assigned this Jan 17, 2020
aksh1t
aksh1t approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@aksh1t aksh1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this works. Changes LGTM.

@radazzouz radazzouz merged commit 60eab4a into master Jan 20, 2020
@radazzouz radazzouz deleted the rad/fix-project-warnings branch January 20, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aksh1t aksh1t aksh1t approved these changes

Assignees

@radazzouz radazzouz

Labels
enhancement New feature or request iOS READY TO REVIEW Pull request ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @aksh1t