Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Android part to PSPDFKit 6.1.1 #54

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Update Android part to PSPDFKit 6.1.1 #54

merged 4 commits into from
Jan 21, 2020

Conversation

simoarpe
Copy link
Contributor

@simoarpe simoarpe commented Jan 21, 2020 •
edited
Loading

Resolves https://github.com/PSPDFKit/pspdfkit-flutter/issues/52

Details

Update Android part to PSPDFKit for Android 6.1.1
Update compile Sdk Version to 29
Update Android build tool version to 29.0.1
Update target Sdk version to 29
Update Gradle plugin version to 3.5.2

Fix Dart method Pspdfkit#checkAndroidWriteExternalStoragePermission()
Bump wrapper version to 1.8.0
Bump example version to 1.8.0

Acceptance Criteria

  • Before merging retest all the examples to make sure that they work on both Android and iOS.

@simoarpe simoarpe self-assigned this Jan 21, 2020
@simoarpe simoarpe added the READY TO REVIEW Pull request ready to review label Jan 21, 2020
radazzouz
radazzouz approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I also tested the example project on both Android and iOS and it works great!

@simoarpe simoarpe merged commit 8f8a3e2 into master Jan 21, 2020
@simoarpe simoarpe deleted the simone/update-android-to-6.1.1 branch January 21, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radazzouz radazzouz radazzouz approved these changes

@tomassurin tomassurin tomassurin approved these changes

Assignees

@simoarpe simoarpe

Labels
Android READY TO REVIEW Pull request ready to review update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update PSPDFKit for Android version to 6.1.1
3 participants
@simoarpe @tomassurin @radazzouz