Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PSPDFKit for Android 6.2 #62

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Update to PSPDFKit for Android 6.2 #62

merged 2 commits into from
Mar 4, 2020

Conversation

simoarpe
Copy link
Contributor

@simoarpe simoarpe commented Mar 3, 2020

Resolves #61

Details

  • Update to PSPDFKit for Android 6.2
  • Remove unused file CHANGELOG.md
  • Update Android Gradle plugin to 3.5.3
  • Bump wrapper version to 1.9.0
  • Bump example version to 1.9.0

Acceptance Criteria

  • Before merging retest all the examples to make sure that they work on both Android and iOS.

@simoarpe
Update to PSPDFKit for Android 6.2
3c82bfd 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
@simoarpe simoarpe added Android update READY TO REVIEW Pull request ready to review labels Mar 3, 2020
@simoarpe simoarpe self-assigned this Mar 3, 2020
@simoarpe
Bump example version to 1.9.0
10075fd 
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
tomassurin
tomassurin approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@tomassurin tomassurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

aksh1t
aksh1t approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@aksh1t aksh1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@simoarpe simoarpe merged commit 278df4d into master Mar 4, 2020
@simoarpe simoarpe deleted the simone/61-update-to-pspdfkit-for-android-6.2 branch March 4, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomassurin tomassurin tomassurin approved these changes

@davidschreiber davidschreiber davidschreiber approved these changes

@aksh1t aksh1t aksh1t approved these changes

Assignees

@simoarpe simoarpe

Labels
Android READY TO REVIEW Pull request ready to review update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to PSPDFKit for Android 6.2
4 participants
@simoarpe @aksh1t @davidschreiber @tomassurin