Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for PSPDFKit 10.1 for iOS and Xcode 12.2 #74

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Update for PSPDFKit 10.1 for iOS and Xcode 12.2 #74

merged 2 commits into from
Nov 20, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Nov 16, 2020 •
edited
Loading

Details

This PR updates the plugin for PSPDFKit 10.1 for iOS, Xcode 12.2, and Flutter 1.23.0-18.1.pre.pre.

Acceptance Criteria

  • Before merging retest all the examples to make sure that they work on both Android and iOS.

@radazzouz radazzouz added update iOS READY TO REVIEW Pull request ready to review labels Nov 16, 2020
@radazzouz radazzouz requested a review from aksh1t November 16, 2020 12:49
steipete
steipete approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@steipete steipete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@radazzouz radazzouz merged commit f7d0ea5 into master Nov 20, 2020
@radazzouz radazzouz deleted the rad/ios-10.1-update branch November 20, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steipete steipete steipete approved these changes

@aksh1t aksh1t Awaiting requested review from aksh1t

Assignees
No one assigned
Labels
iOS READY TO REVIEW Pull request ready to review update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @steipete