Update imports for the latest version #83
Conversation
radazzouz
added
Android
bug
There was a problem hiding this comment.
Thank you for fixing this, Rad!
I tested the android example from the readme, and it launches - however I am getting this error: File not found or could not be opened. when I open the file. I double checked that the file is there and that the app was granted permission, not sure what else could be wrong.
There was a problem hiding this comment.
LGTM, thanks for fixing this.
Just a comment on running upgrade.
Also hopfully issues like this can be removed if we take the example code out of the readme and instead focus on example projects which we could pin to a pspdfkit-flutter version.
Seems pretty error prone to have to copy code out of the readme.
| @@ -87,7 +87,7 @@ android { | |||
| ```dart | |||
There was a problem hiding this comment.
I have an issue with get packages where flutter was grabbing an old version of our plugin.
I had to run flutter packages upgrade to upgrade to latest. I think this would only be an issue for updating an existing project but not 100%.
Might be worth adding flutter packages upgrade as a step after flutter packages get in the readme to make sure users don't fall into the same trap.
There was a problem hiding this comment.
@amit-nayar the flutter packages upgrade was required when you created a new Flutter project?
There was a problem hiding this comment.
No, which is why I'm not sure it's necessary in the readme. I thought it might help though for users who may be upgrading their existing projects. But honestly not sure in this case. It should probably be common knowledge for Flutter users. WDYT?
There was a problem hiding this comment.
I did not have to run the command when I created a new project to test this fix. So I would avoid adding an extra integration step if we can avoid it.
|
@radazzouz can you add a changelog entry for this as well? In the monorepo merge I'll add a danger check so we won't need to remember each time 😄 |
Solves https://github.com/PSPDFKit/PSPDFKit/issues/28037
Details
What this PR does:
Acceptance Criteria