Programmatic PDF form filling - iOS #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2018 13:43
…lue, fullyQualifiedName)` API
irgendeinich
approved these changes
Aug 2, 2018
index.js
Outdated
| * @param fullyQualifiedName The fully qualified name of the form element. | ||
| * | ||
| * Returns a promise resolving a dictionary with the following structure: | ||
| * {'formElement' : value} or ['error' : Failied to get the form field value.] |
There was a problem hiding this comment.
You should update the docs, since it's now {'value' : value}
Also error should be an object not an array
{'error' : 'Failed to get the form field value.'}
ios/RCTPSPDFKit/RCTPSPDFKitView.m
Outdated
| } | ||
| } | ||
|
|
||
| return @{@"error": @"Failied to get the form field value."}; |
There was a problem hiding this comment.
Typo in Failied -> Failed
samples/Catalog/Catalog.ios.js
Outdated
| { | ||
| name: 'Programmatic Form Filling', | ||
| description: | ||
| 'Shows how to get and add new annotations using Instant JSON.', |
There was a problem hiding this comment.
Description should be updated.
There was a problem hiding this comment.
Ah! Copy/paste 🤦♂️
steviki
approved these changes
Aug 2, 2018
ios/RCTPSPDFKit/RCTPSPDFKitView.h
Outdated
| - (void)saveCurrentDocument; | ||
|
|
||
| ///Anotations |
Merged
steviki
reviewed
Aug 2, 2018
| * @param fullyQualifiedName The fully qualified name of the form element. | ||
| * | ||
| * Returns a promise resolving a dictionary with the following structure: | ||
| * {'value' : value} or ['error' : Failed to get the form field value.] |
There was a problem hiding this comment.
['error' : Failed to get the form field value.] is still shown as an array literal, while it should be an object.
There was a problem hiding this comment.
Thank you! Fixed in e709bf1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
iOS implementation of #70
Acceptance Criteria
getFormFieldValue(fullyQualifiedName)andsetFormFieldValue(value, fullyQualifiedName)API.