Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if document is valid before adding or removing annotations #209

Merged
merged 6 commits into from
Apr 15, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Apr 11, 2019

Details

Fixes #194

This fixes the issue described in https://github.com/PSPDFKit/react-native/issues/194#issuecomment-482050508. In that sample project annotations were added before the document was loaded. So they were added to an invalid document.

This PR also updates our Xcode projects (RCTPSPDFKit.xcodeproj and Catalog.xcodeproj) to Xcode 10.2 and fixes warnings.

Acceptance Criteria

  • Check if document is valid before adding or removing annotations.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz
Copy link
Contributor Author

The actual fix is f6554fc

steviki and others added 3 commits April 15, 2019 07:21
Co-Authored-By: radazzouz <radazzouz@users.noreply.github.com>
`![document isValid]` -> `!document.isValid`
@radazzouz radazzouz merged commit 4e80b15 into master Apr 15, 2019
@radazzouz radazzouz deleted the rad/document-validation-check branch April 15, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IOS] Calling addAnnotation can crash the whole app.
2 participants