Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the PDFViewPage when asked to by react native. #229

Merged
merged 3 commits into from
May 27, 2019

Conversation

nickwinder
Copy link
Contributor

@nickwinder nickwinder commented May 24, 2019

Fixes : https://github.com/PSPDFKit/react-native/issues/212

Details

There was a lifetime issue when navigating back and forth between views. Now we create a view when react native wants to. The unloading is still handled in UWP.

Acceptance Criteria

@nickwinder nickwinder self-assigned this May 24, 2019
@nickwinder nickwinder merged commit d541e08 into master May 27, 2019
@nickwinder nickwinder deleted the nick/uwp/solve-lifetime-issue branch May 27, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UWP] Promise returned by PSPDFKit.Present(<path>); does not always resolve/reject
2 participants