Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload the entire document when calling addAnnotations #357

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Mar 15, 2020

Details

Before we were only reloading the current visible page when calling addAnnotations. We were making assumptions that users add annotations to the currently displayed page. This can be perceived as a bug (see Z#17956).

How to Reproduce in the Catalog app:

  • Launch the Catalog app and open the Programmatic Annotations example.
  • Scroll to the second page.
  • Tap on the addAnnotations button.
  • Scroll back to the first page.

Expected:

The added annotations should be visible.

Actual:

The added annotations are not visible.

recording

Acceptance Criteria

  • The entire PSPDFViewController is reloaded when using addAnnotations.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense! 👍

@radazzouz radazzouz merged commit e396cc9 into master Mar 16, 2020
@radazzouz radazzouz deleted the rad/reloadData branch March 16, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants