Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hiding the main toolbar #360

Merged
merged 6 commits into from
Mar 26, 2020

Conversation

irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Mar 19, 2020

Details

  • Adds support for hiding the main toolbar using the new hideDefaultToolbar prop. This allows for the old behaviour where the thumbnail bar was shown but the main toolbar wasn't.
  • Adds new "Hiding Toolbar" sample to Catalog app.
  • Adds new "Default Annotation Setting" sample to Native Catalog app to show how to configure annotation defaults.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM 👍 They don't impact iOS.

On iOS, we already had the ability to hide the toolbar with the existing API, so I've added the Catalog example in e6a758a

recording

@radazzouz radazzouz added the iOS label Mar 19, 2020
@radazzouz radazzouz requested a review from steviki March 19, 2020 13:48
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new iOS toolbar hiding Catalog example looks good to me!

@irgendeinich irgendeinich merged commit c8e9142 into master Mar 26, 2020
@irgendeinich irgendeinich deleted the reinhard/property-inspector-sample branch March 26, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants