-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hiding the main toolbar #360
Conversation
… when the user interface view mode would normally show it
…tion to open editing toolbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM 👍 They don't impact iOS.
On iOS, we already had the ability to hide the toolbar with the existing API, so I've added the Catalog example in e6a758a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new iOS toolbar hiding Catalog example looks good to me!
Details
hideDefaultToolbar
prop. This allows for the old behaviour where the thumbnail bar was shown but the main toolbar wasn't.Acceptance Criteria
package.json
,package-lock.json
,samples/Catalog/package.json
, andsamples/NativeCatalog/package.json
(see example commit: 1bf805f).