Add form editing configuration #365
Conversation
| } | ||
|
|
||
| @NonNull | ||
| private PdfActivityConfiguration updateReactPropsInConfiguration(@NonNull PdfActivityConfiguration configuration) { |
There was a problem hiding this comment.
The reasoning behind this method is that iOS defines the enableFormEditing property as well as the configuration. Since the order of react props application is not guaranteed, we need to make sure that the property value is not overriden by the configuration.
There was a problem hiding this comment.
On iOS, the last used option overrides the previous one. For example, if the user sets a value in the configuration, and they later override it in the prop, we will use the most recent one.
index.js
Outdated
| /** | ||
| * Controls whether or not the document's forms are editable. Defaults to forms being editable (true). | ||
| */ | ||
| enableFormEditing: PropTypes.bool, |
There was a problem hiding this comment.
This leads to confusing API on Android where this property has higher importance than the configuration.enableFormEditing (see my comment above https://github.com/PSPDFKit/react-native/pull/365/files#r413992917). Is this really needed for iOS?
There was a problem hiding this comment.
No, the view prop is no longer required.
index.js
Outdated
| /** | ||
| * Controls whether or not the document's forms are editable. Defaults to forms being editable (true). | ||
| */ | ||
| enableFormEditing: PropTypes.bool, |
There was a problem hiding this comment.
Disabling this on iOS not only disables form editing, but also form viewing. Meaning that all forms (including their set value or contents) are essentially hidden.
Is this the desired behavior and does this match the Android behavior?
There was a problem hiding this comment.
Good point! I'll update the iOS implementation if needed to match the Android behaviour.
There was a problem hiding this comment.
On Android this only disables form editing. Widget annotations are still rendered.
The only way I know of to disable form rendering is when the acroforms license is missing.
There was a problem hiding this comment.
I think the Android implementation makes more sense, and also matches what I would expect from enableFormEditing.
@radazzouz On iOS we could use editableAnnotationTypes to exclude widgets to get the same behavior I think.
There was a problem hiding this comment.
Thank you both for the info. I just pushed the changes in 4da5755.
…diting and keep rendering forms
This reverts commit c1e18c5.
Details
Adds
enableFormEditing: booleanto AndroidConfigurationAdapterclass. This maps to PSPDFKit'sPdfActivityConfiguration.Builder#enable/disableFormEditing().Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: 1bf805f).