Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for PSPDFKit 9.4 for iOS #369

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Update for PSPDFKit 9.4 for iOS #369

merged 2 commits into from
Jun 17, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jun 4, 2020

⚠️ Only merge after PSPDFKit 9.4 for iOS is released ⚠️


Details

This PR updates for the upcoming PSPDFKit 9.4 release.

Acceptance Criteria

  • Test the integration in a new React Native project on iOS.
  • Test the integration in the iOS Catalog sample project.
  • Test the integration in the iOS NativeCatalog sample project.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Comment on lines +38 to +39
pod 'PSPDFKit', podspec:'https://customers.pspdfkit.com/pspdfkit-ios/latest.podspec'
pod 'Instant', podspec:'https://customers.pspdfkit.com/instant/latest.podspec'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links do not currently work because 9.4 is not yet release. For testing, please use the staging environment instead.

@radazzouz radazzouz merged commit 8811870 into master Jun 17, 2020
@radazzouz radazzouz deleted the rad/update-for-v9.4 branch June 17, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant