Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where adding images in PdfViewComponent didn't work #375

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Fix issue where adding images in PdfViewComponent didn't work #375

merged 2 commits into from
Aug 13, 2020

Conversation

irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Aug 13, 2020 •
edited
Loading

Details

This fixes an issue where you were unable to add images from the gallery or camera in the PdfViewComponent.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Fix issue where adding images didn't work because the activity result…
ae06731 
… was not delivered to the GalleryImagePickerFragment and CameraImagePickerFragment
@irgendeinich irgendeinich self-assigned this Aug 13, 2020
simoarpe
simoarpe approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@simoarpe simoarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

radazzouz
radazzouz approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not impact iOS.

@irgendeinich irgendeinich merged commit 603a07f into master Aug 13, 2020
@irgendeinich irgendeinich deleted the reinhard/fix-adding-images branch August 13, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radazzouz radazzouz radazzouz approved these changes

@simoarpe simoarpe simoarpe approved these changes

Assignees

@irgendeinich irgendeinich

Labels
Android READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irgendeinich @simoarpe @radazzouz