iOS Catalog Improvements #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 12, 2021 15:18
…ment prop. The order should not be important.
steviki
reviewed
May 19, 2021
| if (view.annotationAuthorName) { | ||
| view.pdfController.document.defaultAnnotationUsername = view.annotationAuthorName; | ||
| } | ||
|
|
||
| view.pdfController.pageIndex = view.pageIndex; |
There was a problem hiding this comment.
👍 to allow setting this after the document is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds several enhancements to the iOS Catalog example project. Here are the release notes:
ConfiguredPDFViewComponentiOS example to show the settings button in navigation bar.pageIndexprop needed to be set before thedocumentprop.Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: ae02732).