Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for PSPDFKit 10.5 for iOS #409

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Update for PSPDFKit 10.5 for iOS #409

merged 3 commits into from
Jul 7, 2021

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jul 7, 2021 •
edited
Loading

Details

Changelog:

  • Update for PSPDFKit 10.5 for iOS.
  • Update the minimum deployment target to iOS 13.0
  • Update the getting started instructions for the Catalog and NativeCatalog example projects.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, samples/Catalog/yarn.lock, samples/NativeCatalog/package.json, and samples/NativeCatalog/yarn.lock (see example commit: b32b4ed).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz self-assigned this Jul 7, 2021
@radazzouz radazzouz marked this pull request as draft July 7, 2021 12:55
@radazzouz radazzouz marked this pull request as ready for review July 7, 2021 13:11
steviki
steviki approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS changes LGTM!

@radazzouz radazzouz force-pushed the rad/update-for-pspdfkit-10.5 branch from 3b398d0 to 9fbf312 Compare July 7, 2021 14:13
davidschreiber
davidschreiber approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@davidschreiber davidschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good here. Thanks a lot!

@radazzouz radazzouz merged commit 2bdacfd into master Jul 7, 2021
@radazzouz radazzouz deleted the rad/update-for-pspdfkit-10.5 branch July 7, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviki steviki steviki approved these changes

@davidschreiber davidschreiber davidschreiber approved these changes

@aksh1t aksh1t Awaiting requested review from aksh1t

Assignees

@radazzouz radazzouz

Labels
Android iOS READY TO REVIEW update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radazzouz @davidschreiber @steviki