Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SensitivityOp interface #126

Closed
ckolbPTB opened this issue Dec 8, 2023 · 1 comment · Fixed by #137
Closed

SensitivityOp interface #126

ckolbPTB opened this issue Dec 8, 2023 · 1 comment · Fixed by #137
Labels
easy Easy one for people to start with priority: high

Comments

@ckolbPTB
Copy link
Collaborator

ckolbPTB commented Dec 8, 2023

The output of the SensitivityOp should be defined via type hinting: https://github.com/PTB-MR/mrpro/blob/770376be712b94bf44e520767fed89cfeb48321c/src/mrpro/operators/_SensitivityOp.py#L26C23-L26C31

forward(self, img_data: torch.Tensor) -> torch.Tensor:
and without torch.Tensor in Returns

Same for adjoint.
@ckolbPTB ckolbPTB added easy Easy one for people to start with priority: high labels Dec 8, 2023
@ckolbPTB
Copy link
Collaborator Author

ckolbPTB commented Dec 8, 2023

Ideally it should also be (other coil..) rather than (all_other coils..) to be more consistent with the rest of the code.

@ckolbPTB ckolbPTB mentioned this issue Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Easy one for people to start with priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean up PTB-MR/mrpro
1 participant
@ckolbPTB