Fixes Trinkets #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly it listened on drop inventory but that is called after dropEquipment (if shouldDropLoot and DO_MOB_LOOT game rule is true) so now it listens on the drop function in LivingEntity.
|
Worked with elytra trinket, create goggles seem to not be working, as in, puts it in every single trinket slot, gonna test another trinket mod and hope create is the exception not the rule (and that elytra trinket was not the exception either), otherwise gonna need to rework that logic quite a bit Create Goggles duplicates Oh boi, not a good omen Lightman's Currency Wallet vanishes/not saved (not sure which for either let's do or lightman's) Ok, probably broken code...... |
…ne, the trinket does not vanish but will be dropped if you have no inventory space available, there is still weird behavior regarding having on the same trinket and grabbing a gravestone with something in the same slot/same trinket, it de-equips the trinket (in the example I tested, the elytra trinket) and both are placed in your inventory or dropped, while fine, will be best to find out what is causing it and fix it
|
Will probably move this to a separate branch, not sure why I didn't do that initially though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes trinkets (as mentioned in the commit message) by changing when the gravestones code is run, previously it listened on drop inventory but that is called after dropEquipment (if shouldDropLoot and DO_MOB_LOOT game rule is true) so now it listens on the drop function in LivingEntity and cancels it if gravestones is enabled.