fix: code review modifications

PThorpe92 · Sep 19, 2024 · 95b7613 · 95b7613
1 parent abdeba0
commit 95b7613
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/frontend/src/Components/ExternalLink.tsx b/frontend/src/Components/ExternalLink.tsx
@@ -13,6 +13,7 @@ export default function ExternalLink({
             className="flex gap-2 body-small text-body-text items-center"
             href={url}
             target="_blank"
+            rel="noopener noreferrer"
         >
             <ArrowTopRightOnSquareIcon className="w-4" />
             {children}

diff --git a/frontend/src/Components/ResourcesCategoryCard.tsx b/frontend/src/Components/ResourcesCategoryCard.tsx
@@ -6,10 +6,8 @@ export default function ResourcesCategoryCard({
 }: {
     category: ResourceCategory;
 }) {
-    const cardClasses = `card card-compact overflow-hidden`;
-
     return (
-        <div className={cardClasses}>
+        <div className="card card-compact overflow-hidden">
             <div className="card-body gap-2">
                 <h3 className="card-title text-sm">{category.name}</h3>
                 {category.links.map((link: ResourceLink) => {

diff --git a/frontend/src/Components/forms/AddResourceCollectionForm.tsx b/frontend/src/Components/forms/AddResourceCollectionForm.tsx
@@ -44,7 +44,7 @@ export default function AddResourceCollectionForm({
                     errors={errors}
                     register={register}
                 />
-                <p className="text-sm text-red-500 mt-2">
+                <p className="text-sm text-error mt-2">
                     To add a collection, you must also add an accompanying link.
                 </p>
                 <TextInput

diff --git a/frontend/src/Pages/ResourcesManagement.tsx b/frontend/src/Pages/ResourcesManagement.tsx
@@ -446,7 +446,7 @@ const ResourceCollectionCardWithActions = ({
     onResourceCollectionClick: (collection: EditableResourceCollection) => void;
     onDeleteCollectionClick: (collectionId: number) => void;
 }) => {
-    const cardClasses = `card card-compact grow overflow-visible ${collection.isModified ? 'bg-pale-yellow' : ''} ${selected ? 'border border-dark-yellow' : ''}`;
+    const cardClasses = `card card-compact grow overflow-visible ${collection.isModified ? 'bg-pale-yellow' : 'bg-inner-background'} ${selected ? 'border border-dark-yellow' : ''}`;
 
     return (
         <div
@@ -549,7 +549,7 @@ const ResourceCollectionEditor = ({
     };
 
     return (
-        <div className="card">
+        <div className="card bg-inner-background">
             <div className="card-body gap-2">
                 <div className="flex justify-between">
                     <h3 className="card-title text-sm">{collection.name}</h3>

diff --git a/frontend/tailwind.config.js b/frontend/tailwind.config.js
@@ -55,7 +55,7 @@ export default {
                     '--inner-background': '#1A3F3B',
                     '--dark-yellow': '#EA9B00',
                     '--primary-yellow': '#FDC601',
-                    '--pale-yellow': '#18ABA0',
+                    '--pale-yellow': '#FFF3D4',
                     '--grey-1': '#737373',
                     '--grey-2': '#999999',
                     '--grey-3': '#CCCCCC',