WIP: fix: try to fix docker job #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JellyBellyDev
changed the title
garak
reviewed
Aug 5, 2023
| @@ -94,7 +94,7 @@ jobs: | |||
|
|
|||
| docker: | |||
|
|
|||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
ubuntu-22.04 would be better. The latest is not predictable, is just like using dev-master in composer...
There was a problem hiding this comment.
I would use latest on pipelines to ensure it goes automatically on newer versions. For building tools, I believe it could be ok. If we are strict on pinning versions then we need to change elsewhere to ping the apt packages otherwise we can't ensure reproducibility (at the moment we are not pinning any package in the dockerfile nor in the pipelines).
I'm happy to give it another round to pin everything, the only downside is that it'll require more maintenance to keep it up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.