Adds a composer-lock badge #153
Conversation
|
@heiglandreas this looks good I'll try in a day I'm in a conference right now 👍 |
|
No Problem at all! ;) Take your time and say Hi to everyone at PHPDay ;) |
| { | ||
| $repo = str_replace('.git', '', $repository->getOriginalObject()->getRepository()); | ||
|
|
||
| $client = new Client(); |
There was a problem hiding this comment.
Would be great to inject and set this into the constructor so we can mock up during test
what do you think? @heiglandreas
There was a problem hiding this comment.
I was thinking the same actually but wanted to see what the test-results would show actually...I'll refactor that later today
There was a problem hiding this comment.
Is possible to add short timeout like 2 secs on client service?
There was a problem hiding this comment.
Of course. That reminds me that I should also add a fallback like "Couldn't test" in case no result could be fetched!
|
The test should have failed though.... |
| $repo = str_replace('.git', '', $repository->getOriginalObject()->getRepository()); | ||
|
|
||
| $client = new Client(); | ||
| $response = $client->get($repo . '/blob/master/composer.lock'); |
There was a problem hiding this comment.
I was thinking do we need the GET or maybe is better the HEAD? would be faster ...
There was a problem hiding this comment.
HEAD would be OK. Get would allow to check whether the composer.lock actually is a composer lock at a later point in time. But then we can move from HEAD to GET as well.
Good spot!
This commit * adds working tests, * alters retrieval from GET to HEAD * adds a timeout * adds the GuzzleClient via DI
|
@heiglandreas great ! What about the frontend stuff? |
This commit adds some frontend-stuff but the automatic change of the composer.lock-badge when a different repository is given does not yet work as somehow the composer.lock-information is not sent when calling the snippets.
|
I can't seem to include the new Thanks |
|
I don't believe it! In travis the information suddenly is available and causes the tests to fail. But I can't see it in the browser.... |
|
Fixed the Browser-issue on my end! |
|
@liuggio Anything else I can/should do? |
|
@heiglandreas great today I'll deploy it :) |
|
@heiglandreas sorry ... did you already tested for non-git repository? |
|
@heiglandreas sorry I had to revert the deploy caused by a problem on prod with dependencies with redisbundle snc/SncRedisBundle#172 (comment) but I've resolved ... I'll try to do it tonight or tomorrow 👍 |
|
That gives me the time to test this with non-git repos.... Do you have an example for a non-git repo? You mean like svn? I'll have to dig through that then. |
|
@heiglandreas we are online with your code 💃 |
No description provided.