Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serverless with bref (v2) #574

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Serverless with bref (v2) #574

wants to merge 4 commits into from

Conversation

fabiocicerchia
Copy link
Collaborator

@fabiocicerchia fabiocicerchia commented Jun 16, 2021 •
edited
Loading

Ref: #332

JellyBellyDev
JellyBellyDev requested changes Jun 16, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
serverless.yml Outdated Show resolved Hide resolved
src/Kernel.php Outdated Show resolved Hide resolved
sys/php/www.conf Show resolved Hide resolved
sys/php/www.conf Show resolved Hide resolved
sys/php/www.conf Show resolved Hide resolved
sys/php/www.conf Show resolved Hide resolved
garak
garak requested changes Jun 16, 2021
View reviewed changes
Copy link
Member

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about switching to the new runtime component?

JellyBellyDev
JellyBellyDev approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

there is nothing to add or modify in the contributing file?

AlessandroMinoccheri
AlessandroMinoccheri approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@garak
Copy link
Member

garak commented Sep 6, 2024

New suggestion: what about leveraging bref Symfony bridge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlessandroMinoccheri AlessandroMinoccheri AlessandroMinoccheri approved these changes

@drAlberT drAlberT drAlberT approved these changes

@JellyBellyDev JellyBellyDev JellyBellyDev approved these changes

@garak garak Awaiting requested review from garak

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabiocicerchia @garak @JellyBellyDev @drAlberT @AlessandroMinoccheri