Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop check canary #681

Merged
merged 4 commits into from
Jan 24, 2022
Merged

fix: stop check canary #681

merged 4 commits into from
Jan 24, 2022

Conversation

JellyBellyDev
Copy link
Member

@JellyBellyDev JellyBellyDev commented Jan 3, 2022

I don't know why but from today I receive the following errors in dev environment that did 500.
I comment the lines in diff and now work!

@fabiocicerchia PTAL

badge-poser-nginx   | 172.18.0.1 - - [03/Jan/2022:09:43:47 +0000] "GET /phpunit/phpunit/composerlock HTTP/1.1" 500 572 "http://poser.local:8001/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36" "-" CACHE[GET@@poser.local@@/phpunit/phpunit/composerlock]:1:-
badge-poser-nginx   | 172.18.0.1 - - [03/Jan/2022:09:43:47 +0000] "GET /phpunit/phpunit/d/daily HTTP/1.1" 500 572 "http://poser.local:8001/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36" "-" CACHE[GET@@poser.local@@/phpunit/phpunit/d/daily]:1:-
badge-poser-nginx   | 172.18.0.1 - - [03/Jan/2022:09:43:47 +0000] "GET /phpunit/phpunit/version HTTP/1.1" 500 572 "http://poser.local:8001/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36" "-" CACHE[GET@@poser.local@@/phpunit/phpunit/version]:1:-
badge-poser-nginx   | 2022/01/03 09:43:47 [error] 29#29: *74 lua entry thread aborted: runtime error: /etc/nginx/conf.d/lua/hook.lua:26: attempt to compare number with nil
badge-poser-nginx   | stack traceback:
badge-poser-nginx   | coroutine 0:
badge-poser-nginx   | 	/etc/nginx/conf.d/lua/hook.lua: in main chunk, client: 172.18.0.1, server: poser.pugx.org, request: "GET /phpunit/phpunit/d/daily HTTP/1.1", host: "poser.local:8001", referrer: "http://poser.local:8001/"
badge-poser-nginx   | 2022/01/03 09:43:47 [error] 29#29: *73 lua entry thread aborted: runtime error: /etc/nginx/conf.d/lua/hook.lua:26: attempt to compare number with nil
badge-poser-nginx   | stack traceback:
badge-poser-nginx   | coroutine 0:
badge-poser-nginx   | 	/etc/nginx/conf.d/lua/hook.lua: in main chunk, client: 172.18.0.1, server: poser.pugx.org, request: "GET /phpunit/phpunit/version HTTP/1.1", host: "poser.local:8001", referrer: "http://poser.local:8001/"
badge-poser-nginx   | 172.18.0.1 - - [03/Jan/2022:09:43:47 +0000] "GET /phpunit/phpunit/dependents HTTP/1.1" 500 572 "http://poser.local:8001/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36" "-" CACHE[GET@@poser.local@@/phpunit/phpunit/dependents]:1:-
badge-poser-nginx   | 2022/01/03 09:43:47 [error] 29#29: *80 lua entry thread aborted: runtime error: /etc/nginx/conf.d/lua/hook.lua:26: attempt to compare number with nil
badge-poser-nginx   | stack traceback:
badge-poser-nginx   | coroutine 0:
badge-poser-nginx   | 	/etc/nginx/conf.d/lua/hook.lua: in main chunk, client: 172.18.0.1, server: poser.pugx.org, request: "GET /phpunit/phpunit/dependents HTTP/1.1", host: "poser.local:8001", referrer: "http://poser.local:8001/"

We can remove the dark canary logic right?

Copy link
Collaborator

@fabiocicerchia fabiocicerchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could remove the entire block.
could you please remove the occurrences of dark-canary from sys/nginx/default.conf.template and sys/cloudformation/stack.yaml? 🙏

sys/nginx/lua/hook.lua Outdated Show resolved Hide resolved
sys/nginx/lua/hook.lua Outdated Show resolved Hide resolved
JellyBellyDev and others added 3 commits January 11, 2022 09:50
Co-authored-by: Fabio Cicerchia <info@fabiocicerchia.it>
Co-authored-by: Fabio Cicerchia <info@fabiocicerchia.it>
@JellyBellyDev
Copy link
Member Author

@fabiocicerchia PTAL

@JellyBellyDev JellyBellyDev merged commit 22ad334 into master Jan 24, 2022
@JellyBellyDev JellyBellyDev deleted the fix/stop-check-canary branch January 24, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants