Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (minor issues) #774

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Refactor (minor issues) #774

merged 2 commits into from
Apr 26, 2022

Conversation

zerai
Copy link
Contributor

@zerai zerai commented Apr 23, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #774 (86e4551) into master (e7dd951) will decrease coverage by 1.18%.
The diff coverage is 88.20%.

@@             Coverage Diff              @@
##             master     #774      +/-   ##
============================================
- Coverage     91.97%   90.78%   -1.19%     
+ Complexity      256      253       -3     
============================================
  Files            40       45       +5     
  Lines           810      738      -72     
============================================
- Hits            745      670      -75     
- Misses           65       68       +3     
Impacted Files Coverage Δ
...Badge/Infrastructure/Package/PackageRepository.php 90.00% <ø> (-1.67%) ⬇️
src/Badge/Infrastructure/ResponseFactory.php 100.00% <ø> (ø)
src/Controller/Badge/CircleCiController.php 0.00% <0.00%> (ø)
src/Service/CircleCiClient.php 100.00% <ø> (ø)
src/Stats/Reader/RedisReader.php 100.00% <ø> (ø)
...c/Badge/Model/UseCase/CreateGitAttributesBadge.php 80.00% <33.33%> (-4.22%) ⬇️
src/Controller/SnippetController.php 50.00% <40.00%> (ø)
src/Service/SnippetGenerator.php 81.81% <47.36%> (-18.19%) ⬇️
src/Contributors/Service/Repository.php 93.10% <75.00%> (-1.35%) ⬇️
src/Controller/Badge/AbstractBadgeController.php 90.00% <80.00%> (-10.00%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f85e6...86e4551. Read the comment docs.

@zerai zerai marked this pull request as ready for review April 23, 2022 13:56
Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JellyBellyDev JellyBellyDev merged commit 225f812 into PUGX:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants