Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mixer from PX4IO; Use Only Direct PWM Passthrough #14142

Closed
JacobCrabill opened this issue Feb 12, 2020 · 9 comments
Closed

Remove Mixer from PX4IO; Use Only Direct PWM Passthrough #14142

JacobCrabill opened this issue Feb 12, 2020 · 9 comments

Comments

@JacobCrabill
Copy link
Member

(Placeholder for discussion on this topic)

Describe problem solved by the proposed feature
The PX4IO processor is running out of memory (particularly for large mixer files)

Describe your preferred solution
A possible solution is to remove the mixer from px4iofirmware, and instead use direct pwm control from the FMU, rather than sending actuator controls.

An example of this direct pwm control can be seen in the 'test' portion of the 'pwm' systemcmd.

Additional context
Other benefits of this change include simpler debugging of PWM outputs, as all mixing input/output would be available for viewing on the FMU.

Also worth noting is that this method is used by ArduPilot, which further leverages this by allowing the mixer mapping to be defined via run-time parameters, rather than baked-in mixer files.

@mrpollo
Copy link
Contributor

mrpollo commented Feb 12, 2020

📌Subscribed

@dlwalter
Copy link
Contributor

This would be fantastic. Currently using 8 simple mixers as a passthrough from an FMU mixer but there's all sorts of weirdness with NANs indicating disarmed that need to be handled and passed correctly.

@jlecoeur
Copy link
Contributor

jlecoeur commented Feb 12, 2020

Related PR: #13581
This adds a pass-through mixer, with the short term goal to make it possible to do mixing on either FMU or IO, and longer term goal to move features from IO to FMU.

@stale
Copy link

stale bot commented May 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label May 15, 2020
@bkueng
Copy link
Member

bkueng commented Oct 25, 2022

Implemented

@bkueng bkueng closed this as completed Oct 25, 2022
@siddux
Copy link

siddux commented Nov 8, 2022

Implemented

Hi, has it been merged into main branch? If not in which branch can I found it?

Also, is there any documentation available?

Thanks.

@bkueng
Copy link
Member

bkueng commented Nov 8, 2022

Yes this is on main. What kind of documentation are you looking for?

@siddux
Copy link

siddux commented Nov 8, 2022

Yes, thanks I've found all I need...a long time without using PX4. Also, regarding documentation I think this page should be updated. It can be confusing with the new implementation using control allocation.

@bkueng
Copy link
Member

bkueng commented Nov 9, 2022

Also, regarding documentation I think this page should be updated. It can be confusing with the new implementation using control allocation.

@hamishwillee apparently we missed one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants