Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMI088 driver cannot be built on posix platform now #15490

Open
UAV-Pilot opened this issue Aug 5, 2020 · 4 comments
Open

BMI088 driver cannot be built on posix platform now #15490

UAV-Pilot opened this issue Aug 5, 2020 · 4 comments

Comments

@UAV-Pilot
Copy link
Contributor

Describe the bug
BMI088 driver is only usable on nuttx platform now. It worked before on posix/linux platform, but now it cannot be built for posix platform in the master branch due to the following:

#include <px4_platform/board_dma_alloc.h>

File px4_platform/board_dma_alloc.h is only available on nuttx platform at this point. The change/improvement for this drive on nuttx platform should not break it on posix platform.

To Reproduce
Steps to reproduce the behavior:

  1. add the following driver to cmake file of a posix board:
    imu/bosch/bmi088
  2. the following build error comes up:

Firmware/src/drivers/imu/bosch/bmi088/BMI088_Gyroscope.cpp:36:10: fatal error: px4_platform/board_dma_alloc.h: No such file or directory
#include <px4_platform/board_dma_alloc.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Expected behavior
BMI088 driver can be built and continues to work on posix platform as before.

@julianoes
Copy link
Contributor

@UAV-Pilot which platform are you actually using?

@UAV-Pilot
Copy link
Contributor Author

I'm using NVidia Jetson Nano, but the problem should exist on any posix/linux platform as file "px4_platform/board_dma_alloc.h" only exists for nuttx.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Dec 25, 2020
@slgrobotics
Copy link
Contributor

The following PR will remove the offending #include <px4_platform/board_dma_alloc.h>:

#23141

I build this code on an Intel/Ubuntu 22.04 machine for Raspberry Pi 4 (arm64) - a Posix system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants