Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check CONFIG_ARCH_BOARD_XXXXX constructs #3146

Closed
davids5 opened this issue Nov 7, 2015 · 3 comments
Closed

Check CONFIG_ARCH_BOARD_XXXXX constructs #3146

davids5 opened this issue Nov 7, 2015 · 3 comments
Assignees
Labels

Comments

@davids5
Copy link
Member

davids5 commented Nov 7, 2015

The cmake conversion did not propagate the following

ARCHDEFINES += -DCONFIG_ARCH_BOARD_$(CONFIG_BOARD)

While this should be OK as long as we maintain our defconfig files (by hand) to ALWAYS have CONFIG_ARCH_BOARD_XXXXX (make oldconfig will break this, and I have to hand merge) it may be good to visit all the #if CONFIG_ARCH_BOARD_XXXXX constructs and ensure a compile time failure will result if missing.

@dagar
Copy link
Member

dagar commented Apr 11, 2017

Does this still need to be fixed?

@davids5
Copy link
Member Author

davids5 commented Apr 11, 2017

This was fixed in the PR that expunged the #if CONFIG_ARCH_BOARD from the code base. I also added a tool to preserver the CONFIG_ARCH_BOARD etal through oldconfig and menuconfig for board configs not know to NuttX.

The remaining are
image
image

Which all look OK for NuttX

I do not see
CONFIG_ARCH_BOARD_RPI
CONFIG_ARCH_BOARD_SIM
set - If you can validate those we can close this.

@davids5
Copy link
Member Author

davids5 commented Sep 29, 2017

Now that most all the CONFIG_ARCH_BOARD_XXXXX are gone! This is no longer an issue on 1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants