-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow out-of-focus takeoff support #6347
Comments
About flow failsafe:
|
Yep, we should add auto-land as an option instead of falling back to manual and we should find and fix the issue which is not making it return. |
@jgoppert You will be interested in this. We should also consolidate the hack in LPE which we currently use to do the out-of-focus takeoffs. |
Any reason not to implement a fake landing measurement like LPE does. This isn't really a hack since it is fusing the extra information that we know when landed. This gives agl = 0, vx=0, vy=0 when landed. During takeoff the measurement goes away and the vehicle is in the air. Then the covariance matrix for x, y is growing. If it gets too large it publishes that position is invalid. So you get a timeout that is adaptive based on the measurements that you have. I think this is the best option. We do need to handle the data better and make sure the vehicle lands. |
@priseborough That change looks reasonable to me. The only other thing you might want to do is add a measurement of agl = 0 to keep the terrain state and altitude state the same. |
What I did with the APM implementation was add a parameter which was the expected on-ground range measurement. In the absence of range data it would use the expected on-ground value if not in-air. This allowed for the variation in landing gear height between copters. |
I think both estimators have working solutions for this now. |
I'm not sure if this is solved. @ChristophTobler? |
Yes, this is solved. Thanks |
Current discussion state:
The text was updated successfully, but these errors were encountered: