Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow out-of-focus takeoff support #6347

Closed
LorenzMeier opened this issue Jan 16, 2017 · 10 comments
Closed

Flow out-of-focus takeoff support #6347

LorenzMeier opened this issue Jan 16, 2017 · 10 comments

Comments

@LorenzMeier
Copy link
Member

Current discussion state:

  • Report flow as valid or special mode if landed (if flow data is coming in)
  • Report sonar / altimeter as zero if landed (if altimeter data is coming in)
  • Once non-landed time-out after 2-3 seconds if either flow or sonar / altimeter do not become valid
  • Ensure position controller goes into failsafe if timing out
  • Takeoff should takeoff action, not user-driven altitude (so the system clears the minimum altitude quickly)
@LorenzMeier
Copy link
Member Author

@ChristophTobler
Copy link
Contributor

ChristophTobler commented Jan 16, 2017

About flow failsafe:

  • In the simulation it does switch to WARN [commander] failsafe mode on after not getting valid measurements (fly outside of asphalt) after a few seconds. But then it just switches to altitude mode (obviously it can not return when it does not have a position information). I guess it should handle that case by just landing?
  • Do what is mentioned above. Then there seems to be a bug when returning to the asphalt manually. It does not always switch back to WARN [commander] failsafe mode off (this is ekf2 specific)

@LorenzMeier
Copy link
Member Author

Yep, we should add auto-land as an option instead of falling back to manual and we should find and fix the issue which is not making it return.

@mhkabir
Copy link
Member

mhkabir commented Jan 16, 2017

@jgoppert You will be interested in this. We should also consolidate the hack in LPE which we currently use to do the out-of-focus takeoffs.

@jgoppert
Copy link
Member

jgoppert commented Jan 17, 2017

Any reason not to implement a fake landing measurement like LPE does. This isn't really a hack since it is fusing the extra information that we know when landed. This gives agl = 0, vx=0, vy=0 when landed. During takeoff the measurement goes away and the vehicle is in the air. Then the covariance matrix for x, y is growing. If it gets too large it publishes that position is invalid. So you get a timeout that is adaptive based on the measurements that you have. I think this is the best option. We do need to handle the data better and make sure the vehicle lands.

@jgoppert
Copy link
Member

@priseborough That change looks reasonable to me. The only other thing you might want to do is add a measurement of agl = 0 to keep the terrain state and altitude state the same.

@priseborough
Copy link
Contributor

What I did with the APM implementation was add a parameter which was the expected on-ground range measurement. In the absence of range data it would use the expected on-ground value if not in-air. This allowed for the variation in landing gear height between copters.

@jgoppert
Copy link
Member

I think both estimators have working solutions for this now.

@mhkabir
Copy link
Member

mhkabir commented Apr 28, 2017

I'm not sure if this is solved. @ChristophTobler?

@ChristophTobler
Copy link
Contributor

Yes, this is solved. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants