Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add Traxxis rover build guide #2688

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

WIP Add Traxxis rover build guide #2688

wants to merge 8 commits into from

Conversation

NickJ98
Copy link

@NickJ98 NickJ98 commented Aug 15, 2023

No description provided.

@github-actions
Copy link

No flaws found

@hamishwillee
Copy link
Collaborator

@NickJ98 This is coming along well. I haven't reviewed it but FYI only I have made some "essential changes" that you would have had to otherwise, so you should rebase before doing further updates.

Changes:

  1. Images and files should all be lower case, no spaces. This makes linking easier and means that the docs build more safely on file systems that are case sensitive.
  2. Images too big - I have cropped where necessary and run a near-lossless compressor over them.
  3. I ran prettier over the docs from VSCode.

A few other changes that I will note inline.

@@ -80,6 +80,7 @@
* [Helicopter (experimental)](frames_helicopter/README.md)
* [Helicopter Config/Tuning](config_heli/README.md)
* [Rovers (experimental)](frames_rover/README.md)
* [Cyber Rover](frames_rover/cyber_rover.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI Added to SUMMARY.md - needed so this appears in the sidebar when built.

## Parts List

- [Traxxas TRX-4 Bronco](https://traxxas.com/products/models/electric/trx-4-bronco)
- [ARK Flow](../dronecan/ark_flow.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where the files exist in our docs I have linked there. Usually there is more useful setup guide etc stuff there.

- [Traxxas TRX-4 Bronco](https://traxxas.com/products/models/electric/trx-4-bronco)
- [ARK Flow](../dronecan/ark_flow.md)
- [2x ARK RTK GPS Modules](../dronecan/ark_rtk_gps.md)
- [ARK Jetson PAB Carrier](https://arkelectron.com/product/ark-jetson-pab-carrier/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to have this also in the docs - we have an ARK PAB carrier doc, but not this one.

@@ -0,0 +1,55 @@
# Cyber Rover (ARK Electronics)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

Suggested change
# Cyber Rover (ARK Electronics)
# Traxxas TRX-4 Cyber Rover (ARK Electronics)

@hamishwillee
Copy link
Collaborator

Hi @NickJ98

This is still marked WIP - just wondering on ETA?

@hamishwillee
Copy link
Collaborator

Hi @NickJ98 Ping!

@hamishwillee
Copy link
Collaborator

Closing. WOuld love this but developer does not have resource to complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants