refactor to remove one if statement in a loop

PabloJoan · Nov 29, 2023 · 43f74fd · 43f74fd
1 parent 3ecbeb4
commit 43f74fd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/src/Bucketing/Id.php b/src/Bucketing/Id.php
@@ -23,7 +23,7 @@ public function strToIntHash(string $idToHash): int
         $hex = hash(self::HASH_ALGO, $idToHash);
         $dec = hexdec($hex);
 
-        $x = $dec / self::TOTAL;
-        return (int) round($x * 100);
+        $x = (int) round($dec / self::TOTAL * 100);
+        return $x === 100 ? 99 : $x;
     }
 }
diff --git a/src/Bucketing/Random.php b/src/Bucketing/Random.php
@@ -18,6 +18,6 @@ public function __construct()
 
     public function strToIntHash(string $idToHash): int
     {
-        return $this->randomizer->getInt(0, 100);
+        return $this->randomizer->getInt(0, 99);
     }
 }
diff --git a/src/Configurations/Config.php b/src/Configurations/Config.php
@@ -39,9 +39,6 @@ public function pickVariantOutOfHat(string $id): string
             if ($hashOrRandomNumber < $variantRange) {
                 return $variant;
             }
-            if ($hashOrRandomNumber === 100 && $variantRange === 100) {
-                return $variant;
-            }
         }
 
         return '';