Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Bundle qt wayland by rtiangha #212

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Miguel-hrvs
Copy link
Contributor

Adds wayland support in the ci linux build

@C-512L
Copy link

C-512L commented Jul 21, 2024

From what I tested, launching citra-qt with QT_QPA_PLATFORM=wayland on GNOME, the UI renders correctly. Also I tried opening a few games, both using Vulkan and OpenGL, and I haven't found any major issue.

@PabloMK7
Copy link
Owner

Can you give more context on what does this improve?

@rtiangha
Copy link
Contributor

rtiangha commented Jul 21, 2024

According to Miguel, it should allow the AppImage to be launched on Wayland systems without having to provide any command line arguments or environment variables (ex. just double click).

@C-512L
Copy link

C-512L commented Jul 21, 2024

According to Miguel, it should allow the AppImage to be launched on Wayland systems without having to provide any command line arguments or environment variables (ex. just double click).

Technically, without this Citra can not even be launched without using Xwayland

@PabloMK7
Copy link
Owner

How is this going to affect non-wayland systems?

@C-512L
Copy link

C-512L commented Jul 22, 2024

How is this going to affect non-wayland systems?

It will not affect them in any way.

@rtiangha
Copy link
Contributor

I had the same concerns; there's a bit more discussion on the old PR:

#73

@PabloMK7 PabloMK7 merged commit e55e619 into PabloMK7:master Jul 25, 2024
12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants