Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[PaddlePaddle Hackathon No.70] Add clip op #878

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

zhangyuqin1998
Copy link
Contributor

No description provided.

@zhangyuqin1998
Copy link
Contributor Author

很奇怪,cinn-gpu-cudnn-off 的 check 里,有一个名叫 test_cinn_real_mobilenetV1 的 test 没通过,这个 test 看起来和我的算子并没有关系,
我的 test_net_builder 和 test_clip 都 pass 了,麻烦任务leader帮忙看一下~

cinn/frontend/net_builder_test.cc Outdated Show resolved Hide resolved
cinn/hlir/op/contrib/clip_test.cc Outdated Show resolved Hide resolved
cinn/frontend/net_builder_test.cc Outdated Show resolved Hide resolved
@zhhsplendid
Copy link
Member

很奇怪,cinn-gpu-cudnn-off 的 check 里,有一个名叫 test_cinn_real_mobilenetV1 的 test 没通过,这个 test 看起来和我的算子并没有关系, 我的 test_net_builder 和 test_clip 都 pass 了,麻烦任务leader帮忙看一下~

没关系,一些测试是有可能随机失败。可以根据PR review意见,修改完意见后再提一个commit,新commit测试会被自动启动。如果到时还有问题,PR留言,我帮你系统重跑测试。

Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit 6a73dbe into PaddlePaddle:develop Aug 29, 2022
@xiaoan17
Copy link

与zhangyuqin1998、fubuki75合作。

@fubuki75
Copy link

与zhangyuqin1998、xiaoan17合作。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants