Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config including #2564

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MistEO
Copy link
Contributor

@MistEO MistEO commented Nov 21, 2024

PR types(PR类型)

Bug Fix

Description

fastdeploy/runtime/enum_variables.cc 这个文件的包含树中没有过 config.h,导致 GetAvailableBackends 函数中的宏都读不到,返回的是个空的 vector

Copy link

paddle-bot bot commented Nov 21, 2024

Thanks for your contribution!

@MistEO
Copy link
Contributor Author

MistEO commented Nov 21, 2024

我感觉这种通过 include 来决定宏的做法是不合理的,很容易有某个文件漏掉 include 导致问题,而且这类问题很难排查。最好应该通过编译参数 -D 把这些宏传进去。不过改动太大了,交给大佬们评估修改了_(:з」∠)_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant