转换规则 No. 153 #181
Merged
转换规则 No. 153 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
需要在PR描述里写上文档PR的链接 |
|
@enkilee 你好，单测没有跑过，因为CI上只有CPU环境无法跑过GPU的环境，可以参考下其他单测这里的写法 |
|
单测未通过 |
|
@enkilee 敏师傅，记得这里还有单测问题哈 |
zhwesky2010
reviewed
Aug 25, 2023
| pytorch_code, | ||
| ["result"], | ||
| unsupport=True, | ||
| reason="paddle does not support this function temporarily", |
There was a problem hiding this comment.
上面不是刚实现了 torch.distributed.all_gather_object 吗，这里怎么能写unsupport呢
There was a problem hiding this comment.
dist.init_process_group("nccl", init_method='tcp://127.0.0.1:23456', rank=1, world_size=3)
这个无法运行
There was a problem hiding this comment.
这个API也是支持的，为啥转完后，会有 >>> 标记呀，按道理应该全部转写了，使用unsupport=True是不能跑过的
|
这个API也是支持的，为啥转完后，会有 >>> 标记呀，按道理应该全部转写了，使用unsupport=True是表示转完后代码里有 >>> 标记的 |
|
收到，立即整改 |
zhwesky2010
previously approved these changes
Sep 4, 2023
zhwesky2010
reviewed
Sep 4, 2023
| pytorch_code = textwrap.dedent( | ||
| """ | ||
| import torch | ||
| import torch.distributed as dist |
There was a problem hiding this comment.
CI上的环境只有CPU，单测中需要判断下if torch is cuda，不然跑不过
zhwesky2010
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
PR APIs