Fix 123 unittests by autofix #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
reviewed
Jan 9, 2024
| @@ -1978,7 +1986,9 @@ | |||
| "memory_format" | |||
| ] | |||
| }, | |||
| "torch.Tensor.lstsq": {}, | |||
| "torch.Tensor.lstsq": { | |||
| "min_input_args": 1 | |||
There was a problem hiding this comment.
这种没有实现的API，也需要加 min_input_args 字段吗
There was a problem hiding this comment.
这个里面的 min_input_arg 是基于 python 函数签名计算的，因为感觉后续用得到所以先加上了，要先移除吗
paconvert/api_mapping.json
Outdated
| @@ -3321,8 +3343,7 @@ | |||
| "min_input_args": 0, | |||
| "args_list": [ | |||
| "dtype", | |||
| "non_blocking", | |||
| "dst_type" | |||
There was a problem hiding this comment.
这个要留着，因为是为了适配torch.nn.Module.type，TensorTypeMatcher里包含torch.nn.Module.type的功能。
tests/test_nn_Module_type.py
Outdated
| def test_case_2(): | ||
| # paddle not support: 'Layer' object has no attribute 'type' | ||
| # convert failed when using keyword argument. | ||
| def _test_case_2(): |
There was a problem hiding this comment.
这个把历史功能弄没了，是在TensorTypeMatcher里实现的
paconvert/api_mapping.json
Outdated
| } | ||
| }, | ||
| "unsupport_args": [ | ||
| "_stacklevel" |
There was a problem hiding this comment.
这个不是直接删除了，对应""，还需要unsupport吗
zhwesky2010
approved these changes
Jan 11, 2024
| "torch.linalg.solve_triangular": 'keyword arg "upper" has no default value', | ||
| "torch.sparse_csr_tensor": "paddle must specified arg `shapes`", | ||
| "torch.nn.GRUCell": "paddle result has diff with pytorch result when all parameters use default value", |
There was a problem hiding this comment.
这些问题case你这边整理下，维护一个像这样的excel吧，不然这些问题永远得不到修复
PaddlePaddle/Paddle#55883
整理好excel列表后给我，我后面推动框架进行升级修复
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
（半）自动修复了 123 个 api 单测。
非特殊情况的常见单测覆盖问题存量已清空。
PR APIs