单测case覆盖2 #455
Merged
单测case覆盖2 #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
reviewed
Aug 21, 2024
paconvert/api_mapping.json
Outdated
| @@ -4755,17 +4755,13 @@ | |||
| "paddle_api": "paddle.bernoulli", | |||
| "args_list": [ | |||
| "input", | |||
| "p", | |||
There was a problem hiding this comment.
这个删得不对吧，文档是有bug的，以实际代码为准
| @@ -1003,6 +1003,7 @@ def get_paddle_nodes(self, args, kwargs): | |||
| else: | |||
| code = "{}({})".format(paddle_api, self.kwargs_to_str(new_kwargs)) | |||
|
|
|||
| self.api_mapping["args_list"] = ["input", "dim", "keepdim", "*", "out"] | |||
There was a problem hiding this comment.
这个已经组装代码完成了，改这个应该没什么意义吧
There was a problem hiding this comment.
这个如果不改的话会影响到后面的testcase。
tests/test_bernoulli.py
Outdated
| result = torch.bernoulli(a, p=0.0) | ||
| a = torch.ones(3, 3) | ||
| out = torch.zeros(3, 3) | ||
| result = torch.bernoulli(a, out=out, generator=torch.Generator()) |
There was a problem hiding this comment.
这个p是支持的，改的时候注意在本地运行代码测试，以实际运行为准，因为torch API文档也可能有bug
zhwesky2010
approved these changes
Aug 23, 2024
|
hi, @Xuxuanang
|
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
单测case覆盖
PR APIs