-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon 7th No.36】为 Paddle 代码转换工具新增 API 转换规则(第 3 组)-part #484
Conversation
Thanks for your contribution! |
@enkilee CI不通过,请自查问题 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
丰富下测试case并自查一遍,以下四种情况的测试case必须全部包含:
- 传入所有参数且全部指定关键字
- 传入所有参数且全部不指定关键字
- 改变关键字顺序
- 默认参数均不指定
…nto hackathon7-part2
同另一个PR,现在最大的问题是通不过数值检查,这个反映了 映射存在Bug 或者 API自身存在Bug。 需要给出明确的结论,最终以通过数值检查为准。 |
恩,找到问题了, blackman没法改,hamming和hann都得改。这边fftbins=perodic,ReverseMatcher在前面那个pr用。但是hann在float32时精度得调低。 |
精度验证适当调低阈值是可以的。但结果完全对不上就得排查是 API自身Bug 还是 API转换的Bug 了。 |
blackman原因写在 479 了。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Docs
PaddlePaddle/docs#6890
PR APIs