【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组） #490

decade-afk · 2024-09-28T04:53:10Z

PR Docs

PR APIs

itemsize
Tensor.bitwise_left_shift
Tensor.bitwise_left_shift_
Tensor.bitwise_right_shift
bitwise_right_shift_
Tensor.col_indices
data_ptr
Tensor.dim_order
Tensor.is_sparse_csr
Tensor.nbytes
Tensor.stride
Tensor.to_sparse_coo
bitwise_left_shift
bitwise_right_shift

paddle-bot · 2024-09-28T04:53:14Z

Thanks for your contribution!

zhwesky2010 · 2024-09-29T09:37:59Z

@decade-afk CI验证单测失败：

2024-09-28 21:06:08 FAILED tests/test_Tensor_itemsize.py::test_case_1 - AttributeError: 'Tensor' ...
2024-09-28 21:06:08 FAILED tests/test_Tensor_itemsize.py::test_case_2 - AttributeError: 'Tensor' ...
2024-09-28 21:06:08 FAILED tests/test_Tensor_itemsize.py::test_case_3 - AttributeError: 'Tensor' ...
2024-09-28 21:06:08 =========== 3 failed, 8161 passed, 100 skipped in 189.87s (0:03:09) ============

zhwesky2010 · 2024-10-16T04:24:02Z

paconvert/api_matcher.py

@@ -436,6 +436,72 @@ def generate_code(self, kwargs):
        return super().generate_code(kwargs)


+class IsSparseCsrMatcher(BaseMatcher):


用 Attribute2Func 这个Matcher就行

zhwesky2010 · 2024-10-16T04:25:04Z

paconvert/api_matcher.py

+
+
+class TensorStrideMatcher(BaseMatcher):
+    def get_paddle_nodes(self, args, kwargs):


这个应该不用重写更底层的get_paddle_nodes，不涉及到可变参数这些，重写generate_code就行

zhwesky2010 · 2024-10-16T04:25:38Z

paconvert/api_matcher.py

+class TensorNbytesMatcher(BaseMatcher):
+    def get_paddle_class_attribute_nodes(self, node):
+        self.parse_func(node)
+        code = "int(paddle.numel({}) * {}.element_size())".format(


按文档改组合方式

zhwesky2010 · 2024-10-16T04:27:03Z

paconvert/api_matcher.py

+        return code
+
+
+class TensorItemsizeMatcher(BaseMatcher):


这么一个简单的示例，无需重写Matcher吧，用GenericMatcher就行

zhwesky2010 · 2024-10-16T04:29:54Z

tests/test_bitwise_left_shift.py

-    )
-
-
-def test_case_4():


这些测试例子也没必要删除，测试越丰富越好，而且你没有测out参数吧

zhwesky2010 · 2024-10-16T04:30:11Z

tests/test_bitwise_right_shift.py

-        unsupport=True,
-        reason="paddle does not support this function temporarily",
-    )
+    obj.run(pytorch_code, ["result"])


out参数是不是没测

已经都改好了

decade-afk · 2024-10-16T08:45:37Z

已经好了，请review，然后那个分布式我属实是不知道该怎么转写
@zhwesky2010

zhwesky2010 · 2024-10-16T13:10:45Z

paconvert/api_matcher.py

+        code = API_TEMPLATE.format(
+                self.get_paddle_api(), kwargs["input"], kwargs["other"]
+            )
+        if "out" in kwargs:


这个是因为out是torch.float32类型的问题吧？如果out与result类型一致就没问题。

zhwesky2010 · 2024-10-16T13:13:34Z

tests/test_bitwise_left_shift.py

@@ -82,10 +67,7 @@ def test_case_4():
        """
    )
    obj.run(
-        pytorch_code,


torch.bitwise_left_shift(input, other)类型是int32，由于out类型为float32，才导致result为float32。out类型使用不对，应该是改成：out=torch.empty(3, dtype=torch.int32) 。

不用去把Matcher改错，去适配这个错误的用法。

确实，现在已经好了，请review

zhwesky2010 · 2024-10-16T13:13:41Z

tests/test_bitwise_right_shift.py

+        out = torch.tensor([])
+        result = torch.bitwise_right_shift(input, other, out=out)
+        """
+    )
    obj.run(


zhwesky2010 · 2024-10-17T04:53:04Z

paconvert/api_matcher.py

+                self.get_paddle_api(), kwargs["input"], kwargs["other"]
+            )
+        if "out" in kwargs:
+            code = "paddle.assign({}, {})".format(code, kwargs["out"])


那你直接用GenericMatcher不就行了？

zhwesky2010 · 2024-10-17T04:53:07Z

paconvert/api_matcher.py

+        return code
+
+
+class BitwiseShiftMatcher(BaseMatcher):


那你直接用GenericMatcher不就行了？

这个忘了，已经改好了，请review

zhwesky2010

LGTM

luotao1 · 2024-10-17T06:48:04Z

hi, @decade-afk

非常感谢你对飞桨的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献，详情可见 https://github.com/luotao1 主页说明。
如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组）

5d46f40

decade-afk added 3 commits September 28, 2024 15:14

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组）

5fed93f

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组）

587e426

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组）

6389a93

paddle-bot bot added the contributor External developers label Sep 28, 2024

luotao1 mentioned this pull request Sep 29, 2024

【Hackathon 7th】开源贡献个人挑战赛 PaddlePaddle/Paddle#68244

Open

luotao1 assigned luotao1 and zhwesky2010 Sep 29, 2024

decade-afk and others added 5 commits October 1, 2024 21:21

Merge branch 'PaddlePaddle:master' into itemsize

c2ddba4

update

4041675

update

bb52abd

update

286b66b

Merge branch 'master' into itemsize

b780348

decade-afk mentioned this pull request Oct 12, 2024

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组）-part PaddlePaddle/docs#6893

Merged

zhwesky2010 reviewed Oct 16, 2024

View reviewed changes

decade-afk added 6 commits October 16, 2024 16:01

update

e402151

Merge branch 'itemsize' of work:decade-afk/PaConvert into itemsize

cfb2a60

update

d1bfb6a

update

1f096fb

update

09be172

update

47bd025

zhwesky2010 reviewed Oct 16, 2024

View reviewed changes

update

e6de29b

zhwesky2010 reviewed Oct 17, 2024

View reviewed changes

update

f6d64fd

zhwesky2010 approved these changes Oct 17, 2024

View reviewed changes

zhwesky2010 merged commit b54dfba into PaddlePaddle:master Oct 17, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组） #490

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组） #490

decade-afk commented Sep 28, 2024 •

edited

Loading

paddle-bot bot commented Sep 28, 2024

zhwesky2010 commented Sep 29, 2024 •

edited

Loading

zhwesky2010 Oct 16, 2024

zhwesky2010 Oct 16, 2024

zhwesky2010 Oct 16, 2024

zhwesky2010 Oct 16, 2024

zhwesky2010 Oct 16, 2024

zhwesky2010 Oct 16, 2024

decade-afk Oct 16, 2024

decade-afk commented Oct 16, 2024

zhwesky2010 Oct 16, 2024

zhwesky2010 Oct 16, 2024

decade-afk Oct 16, 2024

zhwesky2010 Oct 16, 2024

zhwesky2010 Oct 17, 2024

zhwesky2010 Oct 17, 2024

decade-afk Oct 17, 2024

zhwesky2010 left a comment

luotao1 commented Oct 17, 2024

		@@ -436,6 +436,72 @@ def generate_code(self, kwargs):
		return super().generate_code(kwargs)


		class IsSparseCsrMatcher(BaseMatcher):



		class TensorStrideMatcher(BaseMatcher):
		def get_paddle_nodes(self, args, kwargs):

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组） #490

【Hackathon 7th No.42】NO.42 为 Paddle 代码转换工具新增 API 转换规则（第 9 组） #490

Conversation

decade-afk commented Sep 28, 2024 • edited Loading

PR Docs

PR APIs

paddle-bot bot commented Sep 28, 2024

zhwesky2010 commented Sep 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

decade-afk commented Oct 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhwesky2010 left a comment

Choose a reason for hiding this comment

luotao1 commented Oct 17, 2024

decade-afk commented Sep 28, 2024 •

edited

Loading

zhwesky2010 commented Sep 29, 2024 •

edited

Loading