Update interface_value.h

PaddlePaddle · May 1, 2024 · ae6e00e · ae6e00e
1 parent 7ad02ee
commit ae6e00e
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/paddle/pir/include/core/interface_value.h b/paddle/pir/include/core/interface_value.h
@@ -14,6 +14,7 @@
 
 #pragma once
 
+#include <memory>
 #include <set>
 #include <type_traits>
 
@@ -35,7 +36,7 @@ class IR_API InterfaceValue {
   InterfaceValue(InterfaceValue &&) noexcept;
   InterfaceValue &operator=(const InterfaceValue &) = delete;
   InterfaceValue &operator=(InterfaceValue &&) noexcept;
-  ~InterfaceValue();
+  ~InterfaceValue() = default;
   void swap(InterfaceValue &&val) {
     using std::swap;
     swap(type_id_, val.type_id_);
@@ -65,13 +66,14 @@ InterfaceValue InterfaceValue::Get() {
       sizeof(typename Interface::Concept) == sizeof(Model),
       "Compared with Concept, Model class shouldn't define new data members");
 
-  val.model_ = malloc(sizeof(Model));
-  if (val.model_ == nullptr) {
+  void *model_raw = malloc(sizeof(Model));
+  if (model_raw == nullptr) {
     throw("Alloc memory for interface failed.");
   }
   static_assert(std::is_trivially_destructible<Model>::value,
                 "interface models must be trivially destructible");
-  new (val.model_) Model();
+  new (model_raw) Model();
+  val.model_.reset(model_raw);
   return val;
 }